Repository navigation
fix(clickhouse): log why connections fail - #367
Merged
Merged
Conversation
DNS failures, refused connections and untrusted certificates all logged "network error: client error (Connect)". The log gave no way to tell which one to fix. The client keeps the transport's reason only as the error's source. error_text appends each cause. The connector names its endpoint. - connecting to 127.0.0.1:8123: tcp connect error: Connection refused (os error 111) - connecting to clickhouse.invalid:8123: dns error: failed to lookup address information - connecting to 127.0.0.1:8443: invalid peer certificate: UnknownIssuer The tests use a closed loopback port, a .invalid name and a TLS server with a self-signed certificate. Add tower-service as a direct dependency. The lockfile had it through hyper-util.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNS failures, refused connections and untrusted certificates all logged "network error: client error (Connect)". The log gave no way to tell which one to fix.
The client keeps the transport's reason only as the error's source. error_text appends each cause. The connector names its endpoint.
The tests use a closed loopback port, a .invalid name and a TLS server with a self-signed certificate.
Add tower-service as a direct dependency. The lockfile had it through hyper-util.